Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated patternfly to v3.23 #13940

Merged
merged 1 commit into from
Mar 27, 2017
Merged

Conversation

skateman
Copy link
Member

@skateman skateman commented Feb 16, 2017

@skateman
Copy link
Member Author

@miq-bot assign @himdel

@himdel
Copy link
Contributor

himdel commented Feb 16, 2017

@miq-bot add_label euwe/no, ui

@himdel
Copy link
Contributor

himdel commented Feb 16, 2017

Will need to test thoroughly, will do later tonight or tomorrow morning..

@himdel
Copy link
Contributor

himdel commented Feb 16, 2017

.. but I'll be adding issues to the UI PR, so please check there before merging..

@martinpovolny martinpovolny changed the title Updated patternfly to v3.20 [WIP] Updated patternfly to v3.20 Feb 16, 2017
@skateman skateman changed the title [WIP] Updated patternfly to v3.20 [WIP] Updated patternfly to v3.21 Feb 21, 2017
@himdel
Copy link
Contributor

himdel commented Mar 2, 2017

@miq-bot remove_label wip

Copy link
Contributor

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works now 👍

(Except the font is different, which may cause small spacing issues in random places.)

@skateman skateman changed the title [WIP] Updated patternfly to v3.21 Updated patternfly to v3.21 Mar 2, 2017
@miq-bot miq-bot removed the wip label Mar 2, 2017
Copy link
Contributor

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(removing previous review)

@himdel
Copy link
Contributor

himdel commented Mar 3, 2017

@miq-bot miq-bot changed the title Updated patternfly to v3.21 [WIP] Updated patternfly to v3.21 Mar 3, 2017
@miq-bot miq-bot added the wip label Mar 3, 2017
@skateman skateman changed the title [WIP] Updated patternfly to v3.21 [WIP] Updated patternfly to v3.23 Mar 22, 2017
@miq-bot
Copy link
Member

miq-bot commented Mar 22, 2017

Checked commit skateman@de8ecf2 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 👍

@skateman skateman changed the title [WIP] Updated patternfly to v3.23 Updated patternfly to v3.23 Mar 22, 2017
@skateman
Copy link
Member Author

Seems like all the errors are gone since 3.23.0...

@miq-bot miq-bot removed the wip label Mar 22, 2017
@martinpovolny martinpovolny merged commit 7cc617b into ManageIQ:master Mar 27, 2017
@martinpovolny martinpovolny added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 27, 2017
@skateman skateman deleted the patternfly-3.20 branch March 28, 2017 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants