-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated patternfly to v3.23 #13940
Updated patternfly to v3.23 #13940
Conversation
@miq-bot add_label euwe/no, ui |
Will need to test thoroughly, will do later tonight or tomorrow morning.. |
.. but I'll be adding issues to the UI PR, so please check there before merging.. |
6376b2f
to
d44ceb9
Compare
@miq-bot remove_label wip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works now 👍
(Except the font is different, which may cause small spacing issues in random places.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(removing previous review)
@miq-bot add_label wip Reintroducing wip because of https://github.com/angular-ui/bootstrap/wiki/Migration-guide-for-prefixes |
d44ceb9
to
982ea11
Compare
982ea11
to
de8ecf2
Compare
Checked commit skateman@de8ecf2 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Seems like all the errors are gone since 3.23.0... |
Merge together with: ManageIQ/manageiq-ui-classic#402
Related issue: ManageIQ/manageiq-ui-classic#400